Review Request 120312: Port .cpp files from KDELibs4Support

[Jakub Caban]

> On Sept. 26, 2014, 6:11 p.m., Kevin Funk wrote:
> > CMakeLists.txt, line 60
> > <https://git.reviewboard.kde.org/r/120312/diff/4/?file=315075#file315075line60>
> >
> >     That works?
> >     
> >     It's KDev::Serialization.

I have tried with KDev::Serialization and failed:

CMake Warning (dev) at CMakeLists.txt:54 (add_library):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "kdevupload" links to target "KDev::Serialization" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:54 (add_library):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "kdevupload" links to target "KDev::Serialization" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.


Only when I change to KDevPlatformSerialization it succeeded. I have found that Serialization is some kind of alias within KDevPlatform CMake files and that way found working solution. But I don't know CMake enough to tell why it is that way. I just made it work ;)


> On Sept. 26, 2014, 6:11 p.m., Kevin Funk wrote:
> > uploadprofiledlg.cpp, line 119
> > <https://git.reviewboard.kde.org/r/120312/diff/4/?file=315084#file315084line119>
> >
> >     "" -> QString()
> >     
> >     Regarding your TODO, this might be the issue: https://git.reviewboard.kde.org/r/119505/

That was exactly this issue. I have wrapped this hack in #if as issue should be fixed in Qt 5.4 - I hope this solution is elegant enough?


- Jakub


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/#review67497
-----------------------------------------------------------


On Sept. 23, 2014, 9:25 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120312/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 9:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3428c80 
>   kdevuploadplugin.cpp 5261978 
>   profilesfiletree.h c595f32 
>   profilesfiletree.cpp 2c19df0 
>   tests/permissions.cpp 8735c8d 
>   uploadjob.cpp c58db45 
>   uploadpreferences.cpp 0949c92 
>   uploadpreferences.ui ac4c679 
>   uploadprofiledlg.h d363190 
>   uploadprofiledlg.cpp ff234bd 
>   uploadprofileitem.h b17187a 
>   uploadprofileitem.cpp ee4610e 
>   uploadprofilemodel.cpp 16847b2 
>   uploadprojectmodel.h 8379810 
>   uploadprojectmodel.cpp 30db851 
> 
> Diff: https://git.reviewboard.kde.org/r/120312/diff/
> 
> 
> Testing
> -------
> 
> Code compiles and works with 2 regressions:
> - Directory chooser for profile settings always opens user home folder instead of remote view
> - upload job always reports 'Upload cancelled' even after succesfull upload
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140930/a35bb4b0/attachment.html>