<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120312/">https://git.reviewboard.kde.org/r/120312/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 26th, 2014, 6:11 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120312/diff/4/?file=315075#file315075line60" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KDev::KDevPlatformSerialization</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That works?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's KDev::Serialization.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried with KDev::Serialization and failed:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMake Warning (dev) at CMakeLists.txt:54 (add_library):<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Policy CMP0028 is not set: Double colon in target name means ALIAS or<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Use the cmake_policy command to set the policy and suppress this warning.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Target "kdevupload" links to target "KDev::Serialization" but the target<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
was not found. Perhaps a find_package() call is missing for an IMPORTED<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
target, or an ALIAS target is missing?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
This warning is for project developers. Use -Wno-dev to suppress it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMake Warning (dev) at CMakeLists.txt:54 (add_library):<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Policy CMP0028 is not set: Double colon in target name means ALIAS or<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Use the cmake_policy command to set the policy and suppress this warning.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Target "kdevupload" links to target "KDev::Serialization" but the target<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
was not found. Perhaps a find_package() call is missing for an IMPORTED<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
target, or an ALIAS target is missing?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
This warning is for project developers. Use -Wno-dev to suppress it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Only when I change to KDevPlatformSerialization it succeeded. I have found that Serialization is some kind of alias within KDevPlatform CMake files and that way found working solution. But I don't know CMake enough to tell why it is that way. I just made it work ;)</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 26th, 2014, 6:11 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120312/diff/4/?file=315084#file315084line119" style="color: black; font-weight: bold; text-decoration: underline;">uploadprofiledlg.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void UploadProfileDlg::updateUrl(const KUrl& url)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void UploadProfileDlg::updateUrl(const QUrl& url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">99</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KDirSelectDialog</span> <span class="n">dialog</span><span class="p">(</span><span class="n">currentUrl</span><span class="p">(),</span> <span class="nb">false</span><span class="p">,</span> <span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QUrl</span> <span class="n">chosenDir</span> <span class="o">=</span> <span class="n">QFileDialog</span><span class="o">::</span><span class="n">getExistingDirectoryUrl</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="s">""</span><span class="p">,</span> <span class="n">currentUrl</span><span class="p">());</span> <span class="c1">//</span><span class="cs">TODO</span><span class="c1">: Need to find out why it always open home directory instead of obeying currentURL()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"" -> QString()</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding your TODO, this might be the issue: https://git.reviewboard.kde.org/r/119505/</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That was exactly this issue. I have wrapped this hack in #if as issue should be fixed in Qt 5.4 - I hope this solution is elegant enough?</p></pre>
<br />
<p>- Jakub</p>
<br />
<p>On September 23rd, 2014, 9:25 p.m. UTC, Jakub Caban wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2014, 9:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code compiles and works with 2 regressions:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Directory chooser for profile settings always opens user home folder instead of remote view<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- upload job always reports 'Upload cancelled' even after succesfull upload</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3428c80)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(5261978)</span></li>
<li>profilesfiletree.h <span style="color: grey">(c595f32)</span></li>
<li>profilesfiletree.cpp <span style="color: grey">(2c19df0)</span></li>
<li>tests/permissions.cpp <span style="color: grey">(8735c8d)</span></li>
<li>uploadjob.cpp <span style="color: grey">(c58db45)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(0949c92)</span></li>
<li>uploadpreferences.ui <span style="color: grey">(ac4c679)</span></li>
<li>uploadprofiledlg.h <span style="color: grey">(d363190)</span></li>
<li>uploadprofiledlg.cpp <span style="color: grey">(ff234bd)</span></li>
<li>uploadprofileitem.h <span style="color: grey">(b17187a)</span></li>
<li>uploadprofileitem.cpp <span style="color: grey">(ee4610e)</span></li>
<li>uploadprofilemodel.cpp <span style="color: grey">(16847b2)</span></li>
<li>uploadprojectmodel.h <span style="color: grey">(8379810)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(30db851)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120312/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>