Review Request 120312: Port .cpp files from KDELibs4Support

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/#review67497
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120312/#comment47063>

    That works?
    
    It's KDev::Serialization.



profilesfiletree.cpp
<https://git.reviewboard.kde.org/r/120312/#comment47064>

    That works?
    
    The slot is `urlEntered()` (since you've removed the `url` parameter)



tests/permissions.cpp
<https://git.reviewboard.kde.org/r/120312/#comment47067>

    That indeed looks like you want QUrl::fromUserInput or similar here.



uploadprofiledlg.cpp
<https://git.reviewboard.kde.org/r/120312/#comment47065>

    Nitpick: Remove additional whitespace



uploadprofiledlg.cpp
<https://git.reviewboard.kde.org/r/120312/#comment47066>

    "" -> QString()
    
    Regarding your TODO, this might be the issue: https://git.reviewboard.kde.org/r/119505/


- Kevin Funk


On Sept. 23, 2014, 9:25 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120312/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 9:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3428c80 
>   kdevuploadplugin.cpp 5261978 
>   profilesfiletree.h c595f32 
>   profilesfiletree.cpp 2c19df0 
>   tests/permissions.cpp 8735c8d 
>   uploadjob.cpp c58db45 
>   uploadpreferences.cpp 0949c92 
>   uploadpreferences.ui ac4c679 
>   uploadprofiledlg.h d363190 
>   uploadprofiledlg.cpp ff234bd 
>   uploadprofileitem.h b17187a 
>   uploadprofileitem.cpp ee4610e 
>   uploadprofilemodel.cpp 16847b2 
>   uploadprojectmodel.h 8379810 
>   uploadprojectmodel.cpp 30db851 
> 
> Diff: https://git.reviewboard.kde.org/r/120312/diff/
> 
> 
> Testing
> -------
> 
> Code compiles and works with 2 regressions:
> - Directory chooser for profile settings always opens user home folder instead of remote view
> - upload job always reports 'Upload cancelled' even after succesfull upload
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140926/1445a25e/attachment-0001.html>