Review Request 120241: Add include path completion
Sergey Kalinichev
kalinichev.so.0 at gmail.com
Thu Sep 18 11:57:13 UTC 2014
> On Sept. 17, 2014, 2 p.m., Milian Wolff wrote:
> > codecompletion/CMakeLists.txt, line 11
> > <https://git.reviewboard.kde.org/r/120241/diff/1/?file=312786#file312786line11>
> >
> > this looks wrong. link against duchain where necessary (but not here).
See my comment below
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120241/#review66721
-----------------------------------------------------------
On Sept. 18, 2014, 3:56 p.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120241/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 3:56 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> While the general idea borrowed from oldcpp, the code is mostly rewritten anew.
>
>
> Diffs
> -----
>
> tests/test_codecompletion.h f9870ea
> tests/test_codecompletion.cpp d141fc6
> codecompletion/CMakeLists.txt 6d6f9a8
> codecompletion/includepathcompletioncontext.h PRE-CREATION
> codecompletion/includepathcompletioncontext.cpp PRE-CREATION
> codecompletion/model.cpp 114f885
> duchain/clangfilehelpers.cpp PRE-CREATION
> duchain/clanghelpers.cpp 93f4298
> duchain/navigationwidget.h 8283bb6
> duchain/navigationwidget.cpp 97010c1
>
> Diff: https://git.reviewboard.kde.org/r/120241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140918/bb30a6fa/attachment.html>
More information about the KDevelop-devel
mailing list