Review Request 120241: Add include path completion

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120241/#review66722
-----------------------------------------------------------



codecompletion/includepathcompletioncontext.cpp
<https://git.reviewboard.kde.org/r/120241/#comment46519>

    Isn't "#   include" (with whitespace inbetween) also valid? Not sure how many projects use this, but it seems to me that that assert could trigger in such cases.



codecompletion/includepathcompletioncontext.cpp
<https://git.reviewboard.kde.org/r/120241/#comment46521>

    Why line .count('"'), but line .endsWith('>'),
    
    There could be a comment after the include. E.g. `#include <foo.h> //TODO: forward declare instead`



codecompletion/model.cpp
<https://git.reviewboard.kde.org/r/120241/#comment46520>

    Spaces between # and include are also allowed


- Alexander Richardson


On Sept. 17, 2014, 11:28 vorm., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120241/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 11:28 vorm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> While the general idea borrowed from oldcpp, the code is mostly rewritten anew.
> 
> 
> Diffs
> -----
> 
>   codecompletion/CMakeLists.txt 6d6f9a8 
>   codecompletion/includepathcompletioncontext.h PRE-CREATION 
>   codecompletion/includepathcompletioncontext.cpp PRE-CREATION 
>   codecompletion/model.cpp 114f885 
>   duchain/clangfilehelpers.cpp PRE-CREATION 
>   duchain/clanghelpers.cpp 93f4298 
>   duchain/navigationwidget.h 8283bb6 
>   duchain/navigationwidget.cpp 97010c1 
> 
> Diff: https://git.reviewboard.kde.org/r/120241/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140917/48347010/attachment.html>