Review Request 120241: Add include path completion

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120241/#review66741
-----------------------------------------------------------



codecompletion/includepathcompletioncontext.cpp
<https://git.reviewboard.kde.org/r/120241/#comment46532>

    Nitpick: Newline before {



duchain/clangfilehelpers.cpp
<https://git.reviewboard.kde.org/r/120241/#comment46531>

    Why did you move those impls into a separate file?


Code looks good. But please add tests.

- Kevin Funk


On Sept. 17, 2014, 9:28 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120241/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 9:28 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> While the general idea borrowed from oldcpp, the code is mostly rewritten anew.
> 
> 
> Diffs
> -----
> 
>   codecompletion/CMakeLists.txt 6d6f9a8 
>   codecompletion/includepathcompletioncontext.h PRE-CREATION 
>   codecompletion/includepathcompletioncontext.cpp PRE-CREATION 
>   codecompletion/model.cpp 114f885 
>   duchain/clangfilehelpers.cpp PRE-CREATION 
>   duchain/clanghelpers.cpp 93f4298 
>   duchain/navigationwidget.h 8283bb6 
>   duchain/navigationwidget.cpp 97010c1 
> 
> Diff: https://git.reviewboard.kde.org/r/120241/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140917/966e6c35/attachment.html>