Review Request 120617: Added the "callable" type hint.

Miquel Sabaté Solà mikisabate at gmail.com
Fri Oct 17 09:11:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120617/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 9:11 a.m.)


Review request for KDevelop, Milian Wolff and Niko Sams.


Changes
-------

The expressionvisitor will evaluate it as a mixed type and not a function. This is made this way so it's consistent with variables assigned to functions.


Repository: kdev-php


Description
-------

As described in [here](http://php.net/manual/en/language.oop5.typehinting.php), as of PHP 5.4 you can set the "callable" type hint. This patch add this feature to the parser.


Diffs (updated)
-----

  parser/test/lexertest.cpp ea8f8d3 
  duchain/expressionvisitor.cpp 1ddb928 
  duchain/tests/duchain.h 8898bf0 
  duchain/tests/duchain.cpp cf54222 
  parser/php.g 9219180 
  parser/phplexer.cpp 8d75428 
  parser/test/lexertest.h eecbfc7 

Diff: https://git.reviewboard.kde.org/r/120617/diff/


Testing
-------

I've added a lexer test + manual testing.


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141017/19f87552/attachment.html>


More information about the KDevelop-devel mailing list