<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120617/">https://git.reviewboard.kde.org/r/120617/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Milian Wolff and Niko Sams.</div>
<div>By Miquel Sabaté Solà.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2014, 9:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The expressionvisitor will evaluate it as a mixed type and not a function. This is made this way so it's consistent with variables assigned to functions.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-php
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As described in <a href="http://php.net/manual/en/language.oop5.typehinting.php" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">here</a>, as of PHP 5.4 you can set the "callable" type hint. This patch add this feature to the parser.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've added a lexer test + manual testing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>parser/test/lexertest.cpp <span style="color: grey">(ea8f8d3)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(1ddb928)</span></li>
<li>duchain/tests/duchain.h <span style="color: grey">(8898bf0)</span></li>
<li>duchain/tests/duchain.cpp <span style="color: grey">(cf54222)</span></li>
<li>parser/php.g <span style="color: grey">(9219180)</span></li>
<li>parser/phplexer.cpp <span style="color: grey">(8d75428)</span></li>
<li>parser/test/lexertest.h <span style="color: grey">(eecbfc7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120617/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>