Review Request 120617: Added the "callable" type hint.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120617/#review68599
-----------------------------------------------------------

Ship it!


a test for the type would be appreciated, otherwise looks good to me.

- Milian Wolff


On Oct. 17, 2014, 8:30 a.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120617/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 8:30 a.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and Niko Sams.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> As described in [here](http://php.net/manual/en/language.oop5.typehinting.php), as of PHP 5.4 you can set the "callable" type hint. This patch add this feature to the parser.
> 
> 
> Diffs
> -----
> 
>   duchain/expressionvisitor.cpp 1ddb928 
>   parser/php.g 9219180 
>   parser/phplexer.cpp 8d75428 
>   parser/test/lexertest.h eecbfc7 
>   parser/test/lexertest.cpp ea8f8d3 
> 
> Diff: https://git.reviewboard.kde.org/r/120617/diff/
> 
> 
> Testing
> -------
> 
> I've added a lexer test + manual testing.
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141017/7e0ab08d/attachment-0001.html>