Review Request 119209: fix build for applications

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119209/#review62074
-----------------------------------------------------------



vcs/dvcs/dvcsjob.h
<https://git.reviewboard.kde.org/r/119209/#comment43177>

    Thats not the correct fix IMO. It should be
    
    #include "../vcsexport.h"
    
    Assuming that vcsexport.h is one level above dvcsjob.h's position.
    
    Reason is to favor the vcsexport.h that is placed 'next' to the dvcsjob.h over any other file named the same way that happens to be in a directory given to the compile via -I.


- Andreas Pakulat


On July 10, 2014, 11:20 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119209/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 11:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> fix build for applications
> 
> Applications which depend on kdevplatformvcs weren't able to build
> because DvcsJob wasn't able to find "vcsexport.h".
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.h f0d5aeecf8c20b5cd01a86c40d6184db6370301e 
> 
> Diff: https://git.reviewboard.kde.org/r/119209/diff/
> 
> 
> Testing
> -------
> 
> kdevplatform, kdevelop and plasmate builds with this patch.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140710/a495f6d0/attachment.html>