Review Request 119209: fix build for applications

[Kevin Funk]

> On July 10, 2014, 1:40 p.m., Andreas Pakulat wrote:
> > vcs/dvcs/dvcsjob.h, line 35
> > <https://git.reviewboard.kde.org/r/119209/diff/1/?file=289582#file289582line35>
> >
> >     Thats not the correct fix IMO. It should be
> >     
> >     #include "../vcsexport.h"
> >     
> >     Assuming that vcsexport.h is one level above dvcsjob.h's position.
> >     
> >     Reason is to favor the vcsexport.h that is placed 'next' to the dvcsjob.h over any other file named the same way that happens to be in a directory given to the compile via -I.

The problem is that "Assuming that vcsexport.h is one level above dvcsjob.h's position." is no longer true:

vcsexport.h is now auto-generated (via generate_export_headers) into the build folder (i.e. $BUILD/vcs/vcsexport.h).

Referring to "../vcsexport.h" won't work for users of dvcsjob.h then. Every file including dvcsjob.h would have to add $BUILD/vcs/dvcs to the include path (-I).

Using fully-qualified names for referring to vcs/vcsexport.h seems to be the only viable option to me. Other suggestions?

PS: This is just *one* example. The problem exists for all headers doing relative imports of their respective export header.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119209/#review62074
-----------------------------------------------------------


On July 10, 2014, 11:20 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119209/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 11:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> fix build for applications
> 
> Applications which depend on kdevplatformvcs weren't able to build
> because DvcsJob wasn't able to find "vcsexport.h".
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.h f0d5aeecf8c20b5cd01a86c40d6184db6370301e 
> 
> Diff: https://git.reviewboard.kde.org/r/119209/diff/
> 
> 
> Testing
> -------
> 
> kdevplatform, kdevelop and plasmate builds with this patch.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140710/b7941beb/attachment-0001.html>