Review Request 119209: fix build for applications
Giorgos Tsiapaliokas
giorgos.tsiapaliokas at kde.org
Thu Jul 10 17:09:43 UTC 2014
> On July 10, 2014, 2:46 p.m., Milian Wolff wrote:
> > vcs/dvcs/dvcsjob.h, line 36
> > <https://git.reviewboard.kde.org/r/119209/diff/1/?file=289582#file289582line36>
> >
> > isn't this line problematic then as well?
plasmate and kdevelop builds but yes IMO that is not the best approach.
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119209/#review62068
-----------------------------------------------------------
On July 10, 2014, 2:20 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119209/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 2:20 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> fix build for applications
>
> Applications which depend on kdevplatformvcs weren't able to build
> because DvcsJob wasn't able to find "vcsexport.h".
>
>
> Diffs
> -----
>
> vcs/dvcs/dvcsjob.h f0d5aeecf8c20b5cd01a86c40d6184db6370301e
>
> Diff: https://git.reviewboard.kde.org/r/119209/diff/
>
>
> Testing
> -------
>
> kdevplatform, kdevelop and plasmate builds with this patch.
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140710/439c968b/attachment.html>
More information about the KDevelop-devel
mailing list