Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Mikhail Krutov]

> On Jan. 27, 2014, 12:35 p.m., Sergey Kalinichev wrote:
> > Hi!
> > I've just tested your patch, but it doesn't solve the problem from https://bugs.kde.org/show_bug.cgi?id=327931
> > 
> > So the questions are:
> > 1. Why did you remove all that code from the 2 revision? It fixes the problem, but the dialog appears at the wrong time (whenever you start kdevelop), but it should whenever you actually use git.
> > 
> > 2. Are you still interested in solving the original 327931 bug? 
> > If not please rename Summary entry to something more appropriate, also remove bug's entry (obviously this patch doesn't solve it anymore).
> > And then I'll try to fix that bug myself as I find it very annoying.

Hello Sergey!
>From my point of view, original problem was that user doesn't get notified of his git problems;
Also the missing user.name/user.email do not 100% guarantee that there would be a fail with git <action> (see previous comments).
I did not find the way of checking if git can autoresolve its troubles (e.g. guess email and/or name of user), except for symptoms (e.g. failing to commit/create/push, and thus substituted fix with displaying the stdout/stderr of git after git commit, which did not happen before & which I find more annoying problem. 
If this variant is less acceptable than patch v2, then of course I'm renaming the summary to something more related to this particular patch. 


- Mikhail


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/#review48379
-----------------------------------------------------------


On Jan. 23, 2014, 10:50 p.m., Mikhail Krutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115232/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 10:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=327931
> When user did not setup git config user.email && user.name, get current KUser.fullName & prompt user to enter his email.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp a582b0a 
> 
> Diff: https://git.reviewboard.kde.org/r/115232/diff/
> 
> 
> Testing
> -------
> 
> Install kdevgit.so plugin, then run KDevelop, init repo, try to commit
> Run KDevelop again with new plugin, pull repo, remove .gitconfig, try to commit
> 
> 
> Thanks,
> 
> Mikhail Krutov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140127/78d4cff0/attachment.html>