<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115232/">https://git.reviewboard.kde.org/r/115232/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2014, 12:35 p.m. UTC, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi!
I've just tested your patch, but it doesn't solve the problem from https://bugs.kde.org/show_bug.cgi?id=327931
So the questions are:
1. Why did you remove all that code from the 2 revision? It fixes the problem, but the dialog appears at the wrong time (whenever you start kdevelop), but it should whenever you actually use git.
2. Are you still interested in solving the original 327931 bug?
If not please rename Summary entry to something more appropriate, also remove bug's entry (obviously this patch doesn't solve it anymore).
And then I'll try to fix that bug myself as I find it very annoying.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello Sergey!
>From my point of view, original problem was that user doesn't get notified of his git problems;
Also the missing user.name/user.email do not 100% guarantee that there would be a fail with git <action> (see previous comments).
I did not find the way of checking if git can autoresolve its troubles (e.g. guess email and/or name of user), except for symptoms (e.g. failing to commit/create/push, and thus substituted fix with displaying the stdout/stderr of git after git commit, which did not happen before & which I find more annoying problem.
If this variant is less acceptable than patch v2, then of course I'm renaming the summary to something more related to this particular patch. </pre>
<br />
<p>- Mikhail</p>
<br />
<p>On January 23rd, 2014, 10:50 p.m. UTC, Mikhail Krutov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Mikhail Krutov.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2014, 10:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://bugs.kde.org/show_bug.cgi?id=327931
When user did not setup git config user.email && user.name, get current KUser.fullName & prompt user to enter his email.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Install kdevgit.so plugin, then run KDevelop, init repo, try to commit
Run KDevelop again with new plugin, pull repo, remove .gitconfig, try to commit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(a582b0a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115232/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>