Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/#review48379
-----------------------------------------------------------


Hi!
I've just tested your patch, but it doesn't solve the problem from https://bugs.kde.org/show_bug.cgi?id=327931

So the questions are:
1. Why did you remove all that code from the 2 revision? It fixes the problem, but the dialog appears at the wrong time (whenever you start kdevelop), but it should whenever you actually use git.

2. Are you still interested in solving the original 327931 bug? 
If not please rename Summary entry to something more appropriate, also remove bug's entry (obviously this patch doesn't solve it anymore).
And then I'll try to fix that bug myself as I find it very annoying.

- Sergey Kalinichev


On Jan. 24, 2014, 2:50 a.m., Mikhail Krutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115232/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 2:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=327931
> When user did not setup git config user.email && user.name, get current KUser.fullName & prompt user to enter his email.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp a582b0a 
> 
> Diff: https://git.reviewboard.kde.org/r/115232/diff/
> 
> 
> Testing
> -------
> 
> Install kdevgit.so plugin, then run KDevelop, init repo, try to commit
> Run KDevelop again with new plugin, pull repo, remove .gitconfig, try to commit
> 
> 
> Thanks,
> 
> Mikhail Krutov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140127/d084521c/attachment.html>