Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/#review48053
-----------------------------------------------------------


Git already has support for finding out the username and depending on the system configuration this could even be sufficient already. So this should just be a hint that there are no values configured and what defaults are going to be used by git IMO, its not necessarily an error.

- Andreas Pakulat


On Jan. 22, 2014, 3:34 p.m., Mikhail Krutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115232/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 3:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=327931
> When user did not setup git config user.email && user.name, throw an error & disallow using git.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.cpp 14d6072 
> 
> Diff: https://git.reviewboard.kde.org/r/115232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mikhail Krutov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140122/815cd2e3/attachment.html>