Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Mikhail Krutov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/
-----------------------------------------------------------

(Updated Jan. 22, 2014, 9:51 p.m.)


Review request for KDevelop.


Changes
-------

I've updated the patch with following logic: 
if any of user.name|user.email is empty, show KDialog, requesting user to validate his name & enter his e-mail address.
I'm a pretty inexperienced coder (e.g. 0 experience (almost)), so please point out all my mistakes in it.


Repository: kdevplatform


Description (updated)
-------

https://bugs.kde.org/show_bug.cgi?id=327931
When user did not setup git config user.email && user.name, get current KUser.fullName & prompt user to enter his email.


Diffs (updated)
-----

  plugins/git/gitplugin.h 0d50dbe 
  plugins/git/gitplugin.cpp abd7e7f 

Diff: https://git.reviewboard.kde.org/r/115232/diff/


Testing (updated)
-------

Install kdevgit.so plugin, then run KDevelop with empty ~/.gitconfig & with valid ~/.gitconfig
This patch has an issue that KDialog is not an active window on KDevelop start (e.g. KDevelop takes WM focus).


Thanks,

Mikhail Krutov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140122/84314244/attachment-0001.html>