Review Request 115232: Check that git configuration has user.email & user.name before allowing to use git.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115232/#review48050
-----------------------------------------------------------


I don't think we want blocking calls in the plugin construction, also a message box saying the user has been nasty probably doesn't help much.

What we could do though, is to identify this specific error and provide solutions to the user, for example asking KDE/XDG about the user name and e-mail and set up these git values, if the user agrees to it.

- Aleix Pol Gonzalez


On Jan. 22, 2014, 3:34 p.m., Mikhail Krutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115232/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 3:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=327931
> When user did not setup git config user.email && user.name, throw an error & disallow using git.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.cpp 14d6072 
> 
> Diff: https://git.reviewboard.kde.org/r/115232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mikhail Krutov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140122/f3b0ea23/attachment-0001.html>