Review Request 115904: Fix lost pyInitLock.unlock and Py_Finalize in astbuilder

[Alexandr Zamaraev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115904/
-----------------------------------------------------------

(Updated Feb. 22, 2014, 4:13 p.m.)


Review request for KDevelop and Sven Brauch.


Changes
-------

I have commit for self. :)

It fix lost Py_Finalize and PyArena_Free in 184-188 lines.
And prevent same bags in future.
Also it isolate Python init/finalize logic from parse logic.

I try find solve problem 331084: Some python file do not parse.


Repository: kdev-python


Description
-------

In some case forget call unlock() for mutex pyInitLock and forget call Py_Finalize() in AstBuilder::parse.
use RAII to prevent it.


Diffs (updated)
-----

  parser/astbuilder.cpp 519bc55 

Diff: https://git.reviewboard.kde.org/r/115904/diff/


Testing
-------


Thanks,

Alexandr Zamaraev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140222/c433369f/attachment-0001.html>