Review Request 115904: Fix lost pyInitLock.unlock and Py_Finalize in astbuilder

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115904/#review50307
-----------------------------------------------------------

Ship it!


Cool, thanks! That has been bad for a while.

I would however not put this into 1.6 -- unless it fixes an actually visible bug ...?

Do you have commit access yourself?


parser/astbuilder.cpp
<https://git.reviewboard.kde.org/r/115904/#comment35405>

    maybe PythonInitializer? "Initer" sounds weird ;)



parser/astbuilder.cpp
<https://git.reviewboard.kde.org/r/115904/#comment35404>

    indentation is weird here



parser/astbuilder.cpp
<https://git.reviewboard.kde.org/r/115904/#comment35406>

    unrelated changes, please avoid


- Sven Brauch


On Feb. 20, 2014, 5:32 a.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115904/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 5:32 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> In some case forget call unlock() for mutex pyInitLock and forget call Py_Finalize() in AstBuilder::parse.
> use RAII to prevent it.
> 
> 
> Diffs
> -----
> 
>   parser/astbuilder.cpp 519bc55 
> 
> Diff: https://git.reviewboard.kde.org/r/115904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140220/77fe5aff/attachment.html>