Review Request 115904: Fix lost pyInitLock.unlock and Py_Finalize in astbuilder

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115904/#review50503
-----------------------------------------------------------

Ship it!


Cool! Feel free to push this as-is and do the other things in a new patch, to keep things separate.

The bug has something to do with encodings. It is probably related to my custom copy of the codecs not being installed correctly, or the python home dir variable not being set properly. In Python 3, this is all gone since the customized copy of Python is no longer there. Thus it works there automatically. But for python 2, I don't know. If you need help, feel free to come to #kdevelop on IRC and we can talk about it.

- Sven Brauch


On Feb. 22, 2014, 9:13 a.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115904/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 9:13 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> In some case forget call unlock() for mutex pyInitLock and forget call Py_Finalize() in AstBuilder::parse.
> use RAII to prevent it.
> 
> 
> Diffs
> -----
> 
>   parser/astbuilder.cpp 519bc55 
> 
> Diff: https://git.reviewboard.kde.org/r/115904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140222/4d2c9efb/attachment.html>