Review Request 115904: Fix lost pyInitLock.unlock and Py_Finalize in astbuilder

Alexandr Zamaraev tonal.promsoft at gmail.com
Thu Feb 20 05:35:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115904/#review50297
-----------------------------------------------------------



parser/astbuilder.cpp
<https://git.reviewboard.kde.org/r/115904/#comment35401>

    This function works like Py_Initialize() if initsigs is 1. If initsigs is 0, it skips initialization registration of signal handlers, which might be useful when Python is embedded.


- Alexandr Zamaraev


On Feb. 20, 2014, 12:32 p.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115904/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 12:32 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> In some case forget call unlock() for mutex pyInitLock and forget call Py_Finalize() in AstBuilder::parse.
> use RAII to prevent it.
> 
> 
> Diffs
> -----
> 
>   parser/astbuilder.cpp 519bc55 
> 
> Diff: https://git.reviewboard.kde.org/r/115904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140220/a5555b64/attachment.html>


More information about the KDevelop-devel mailing list