Review Request 115904: Fix lost pyInitLock.unlock and Py_Finalize in astbuilder

Alexandr Zamaraev tonal.promsoft at gmail.com
Thu Feb 20 05:32:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115904/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 12:32 p.m.)


Review request for KDevelop and Sven Brauch.


Changes
-------

Correct diff for branch 1.6

Sorry for whitespace - reviewboard do not applay path created with --ignore-space-at-eol flag


Repository: kdev-python


Description
-------

In some case forget call unlock() for mutex pyInitLock and forget call Py_Finalize() in AstBuilder::parse.
use RAII to prevent it.


Diffs (updated)
-----

  parser/astbuilder.cpp 519bc55 

Diff: https://git.reviewboard.kde.org/r/115904/diff/


Testing
-------


Thanks,

Alexandr Zamaraev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140220/f84fef89/attachment.html>


More information about the KDevelop-devel mailing list