Review Request 113815: Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"

[Kevin Funk]

> On Feb. 8, 2014, 10:52 a.m., Kevin Funk wrote:
> > languages/cpp/codegen/unresolvedincludeassistant.cpp, line 77
> > <https://git.reviewboard.kde.org/r/113815/diff/3/?file=242364#file242364line77>
> >
> >     Since the *text() getters are gone now, just use *url().isValid() instead of isEmpty().
> >     
> >     For the last test, just compare the two KUrl values against each other (KUrl overloads operator==()).
> 
> Meenakshi Khorana wrote:
>     @kevin : As per documentation, isValid() returns true if every part of the URL conforms to the standard encoding rules of the URI standard for the URL whereas isEmpty returns true only, if the string is null. 
>     
>     This means isValid() will return true in those cases also when url is non-empty and is valid. This will alter the outcome of if statement. Should we not use bool QUrl::isEmpty () const instead of bool QUrl::isValid () const. Please suggest.

I don't quite understand. I wanted you to use the negation of QUrl::isValid() of course. e.g. 'customIncludePathDialog.buildDirectoryText().trimmed().isEmpty()' => '!customIncludePathDialog.buildDirectoryUrl().isValid()'. Does it make sense to you then?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113815/#review49242
-----------------------------------------------------------


On Feb. 7, 2014, 1:22 p.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113815/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 1:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 221792
>     http://bugs.kde.org/show_bug.cgi?id=221792
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths" 
> 
> Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/tests/CMakeLists.txt e049b3b 
>   languages/cpp/CMakeLists.txt bc7b832 
>   languages/cpp/codegen/customincludepaths.h PRE-CREATION 
>   languages/cpp/codegen/customincludepaths.cpp PRE-CREATION 
>   languages/cpp/codegen/ui/custom_include_paths.ui 1a7c1ed 
>   languages/cpp/codegen/unresolvedincludeassistant.cpp 93a72d3 
> 
> Diff: https://git.reviewboard.kde.org/r/113815/diff/
> 
> 
> Testing
> -------
> 
> Compiled and Tested successfully on local machine.
> 
> 
> File Attachments
> ----------------
> 
> Added open file dialog to custom include path
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg
> Folder browser for selecting include paths
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg
> Added include paths will be visible to user in text edit
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140210/44b90649/attachment.html>