Review Request 113815: Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"
Kevin Funk
kfunk at kde.org
Sat Feb 8 10:52:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113815/#review49243
-----------------------------------------------------------
Rest looks fine, if this is fixed we can give it a "Ship it"
- Kevin Funk
On Feb. 7, 2014, 1:22 p.m., Meenakshi Khorana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113815/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 1:22 p.m.)
>
>
> Review request for KDevelop.
>
>
> Bugs: 221792
> http://bugs.kde.org/show_bug.cgi?id=221792
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"
>
> Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.
>
>
> Diffs
> -----
>
> languages/cpp/tests/CMakeLists.txt e049b3b
> languages/cpp/CMakeLists.txt bc7b832
> languages/cpp/codegen/customincludepaths.h PRE-CREATION
> languages/cpp/codegen/customincludepaths.cpp PRE-CREATION
> languages/cpp/codegen/ui/custom_include_paths.ui 1a7c1ed
> languages/cpp/codegen/unresolvedincludeassistant.cpp 93a72d3
>
> Diff: https://git.reviewboard.kde.org/r/113815/diff/
>
>
> Testing
> -------
>
> Compiled and Tested successfully on local machine.
>
>
> File Attachments
> ----------------
>
> Added open file dialog to custom include path
> https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg
> Folder browser for selecting include paths
> https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg
> Added include paths will be visible to user in text edit
> https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg
>
>
> Thanks,
>
> Meenakshi Khorana
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140208/2d6cb280/attachment.html>
More information about the KDevelop-devel
mailing list