<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113815/">https://git.reviewboard.kde.org/r/113815/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 8th, 2014, 10:52 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/113815/diff/3/?file=242364#file242364line77" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/codegen/unresolvedincludeassistant.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">using namespace Cpp;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="n">o</span><span class="p">.</span><span class="n">customIncludePaths</span><span class="o">-></span><span class="n">document</span><span class="p">()</span><span class="o">-></span><span class="n">toPlainText</span><span class="p">().</span><span class="n">trimmed</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">&&</span> <span class="p">(</span><span class="n">o</span><span class="p">.</span><span class="n">sourceDirectory</span><span class="o">-></span><span class="n">text</span><span class="p">().</span><span class="n">trimmed</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">||</span><span class="n">o</span><span class="p">.</span><span class="n">buildDirectory</span><span class="o">-></span><span class="n">text</span><span class="p">().</span><span class="n">trimmed</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">||</span> <span class="n">o</span><span class="p">.</span><span class="n">sourceDirectory</span><span class="o">-></span><span class="n">text</span><span class="p">().</span><span class="n">trimmed</span><span class="p">()</span> <span class="o">==</span> <span class="n">o</span><span class="p">.</span><span class="n">buildDirectory</span><span class="o">-></span><span class="n">text</span><span class="p">().</span><span class="n">trimmed</span><span class="p">())))</span><span class="ew"> </span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="n">customIncludePathDialog</span><span class="p">.</span><span class="n">customIncludePaths</span><span class="p">().</span><span class="n">trimmed</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">&&</span> <span class="p">(</span><span class="n">customIncludePathDialog</span><span class="p">.</span><span class="n">sourceDirectoryText</span><span class="p">().</span><span class="n">trimmed</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">||</span><span class="n">customIncludePathDialog</span><span class="p">.</span><span class="n">buildDirectoryText</span><span class="p">().</span><span class="n">trimmed</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">||</span> <span class="n">customIncludePathDialog</span><span class="p">.</span><span class="n">sourceDirectoryText</span><span class="p">().</span><span class="n">trimmed</span><span class="p">()</span> <span class="o">==</span> <span class="n">customIncludePathDialog</span><span class="p">.</span><span class="n">buildDirectoryText</span><span class="p">().</span><span class="n">trimmed</span><span class="p">())))</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the *text() getters are gone now, just use *url().isValid() instead of isEmpty().
For the last test, just compare the two KUrl values against each other (KUrl overloads operator==()).</pre>
</blockquote>
<p>On February 10th, 2014, 6:35 a.m. UTC, <b>Meenakshi Khorana</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@kevin : As per documentation, isValid() returns true if every part of the URL conforms to the standard encoding rules of the URI standard for the URL whereas isEmpty returns true only, if the string is null.
This means isValid() will return true in those cases also when url is non-empty and is valid. This will alter the outcome of if statement. Should we not use bool QUrl::isEmpty () const instead of bool QUrl::isValid () const. Please suggest.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't quite understand. I wanted you to use the negation of QUrl::isValid() of course. e.g. 'customIncludePathDialog.buildDirectoryText().trimmed().isEmpty()' => '!customIncludePathDialog.buildDirectoryUrl().isValid()'. Does it make sense to you then?</pre>
<br />
<p>- Kevin</p>
<br />
<p>On February 7th, 2014, 1:22 p.m. UTC, Meenakshi Khorana wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Meenakshi Khorana.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2014, 1:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=221792">221792</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"
Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and Tested successfully on local machine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(e049b3b)</span></li>
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(bc7b832)</span></li>
<li>languages/cpp/codegen/customincludepaths.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/codegen/customincludepaths.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/codegen/ui/custom_include_paths.ui <span style="color: grey">(1a7c1ed)</span></li>
<li>languages/cpp/codegen/unresolvedincludeassistant.cpp <span style="color: grey">(93a72d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113815/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg">Added open file dialog to custom include path</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg">Folder browser for selecting include paths</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg">Added include paths will be visible to user in text edit</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>