Review Request 121338: Fix bug on multi-line function-macro expansion, format preprocessed body for Cpp::NavigationWidget

[Zhang HuiJie]

> On 十二月 4, 2014, 4:39 p.m., Kevin Funk wrote:
> > languages/cpp/cpplanguagesupport.cpp, line 859
> > <https://git.reviewboard.kde.org/r/121338/diff/1/?file=331848#file331848line859>
> >
> >     Check if `i` is not null

Thank you. Formating on all macro body was enabled. And it is my mistake that no test will fail because of this patch.


- Zhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121338/#review71322
-----------------------------------------------------------


On 十二月 4, 2014, 9:04 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121338/
> -----------------------------------------------------------
> 
> (Updated 十二月 4, 2014, 9:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Fix bug on multi-line function-macro expansion? format preprocessed body for Cpp::NavigationWidget
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp 79530e9 
>   languages/cpp/parser/rpp/pp-engine.cpp 8f6c8da 
>   languages/cpp/parser/rpp/pp-scanner.h 94fab52 
>   languages/cpp/parser/rpp/pp-scanner.cpp 28479d8 
> 
> Diff: https://git.reviewboard.kde.org/r/121338/diff/
> 
> 
> Testing
> -------
> 
> This patch work well on multi-line function-macro expansion, but TestCppAssistants::testMacroExpansion()  will fail for preprocessed body was formatted.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141204/d0fc15a9/attachment.html>