Review Request 121338: Fix bug on multi-line function-macro expansion, format preprocessed body for Cpp::NavigationWidget

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121338/#review71322
-----------------------------------------------------------


Please refrain from giving yourself a "Ship-It", it's done by reviewers.

Some notes about your code:
- I like the idea (already had that in mind as well)
- This could be useful for non-function macros, too: E.g. consider the Q_OBJECT macro
- Please amend the test to reflect your changes (we don't accept patches that'd break the build)


languages/cpp/cpplanguagesupport.cpp
<https://git.reviewboard.kde.org/r/121338/#comment49803>

    Check if `i` is not null


- Kevin Funk


On Dec. 4, 2014, 1:04 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121338/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 1:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Fix bug on multi-line function-macro expansion? format preprocessed body for Cpp::NavigationWidget
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp 79530e9 
>   languages/cpp/parser/rpp/pp-engine.cpp 8f6c8da 
>   languages/cpp/parser/rpp/pp-scanner.h 94fab52 
>   languages/cpp/parser/rpp/pp-scanner.cpp 28479d8 
> 
> Diff: https://git.reviewboard.kde.org/r/121338/diff/
> 
> 
> Testing
> -------
> 
> This patch work well on multi-line function-macro expansion, but TestCppAssistants::testMacroExpansion()  will fail for preprocessed body was formatted.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141204/f5cc2de6/attachment-0001.html>