[kdev-clang] /: Always update opened in editor documents
kalinichev.so.0 at gmail.com
Wed Aug 27 12:23:52 UTC 2014
Yes, I know that you've already reverted that.
Still I don't understand why is it so bad? Yes, it's just a
workaround, not a proper fix, but it solves the problem. And it does
it almost for free (without using too much resources), because it just
reparses the currently opened document, not it's imports, that already
up to date, so it's very fast.
P.S. Thanks for commenting on my other patches! Yes, I should have
posted it to the review first...
On 8/27/14, Milian Wolff <mail at milianw.de> wrote:
> On Wednesday 27 August 2014 11:29:20 Sergey Kalinichev wrote:
>> Git commit 83b50cbf3707a2e8cd8f1893c262156a3d925493 by Sergey Kalinichev.
>> Committed on 26/08/2014 at 08:12.
>> Pushed by skalinichev into branch 'master'.
>> Always update opened in editor documents
>> This is important as those files won't be reparsed properly after
>> e.g. crash or if they were modified in previous session, but not closed.
> Hello Sergey,
> this patch is wrong I think. It work-arounds an underlying issue. When you
> open KDevelop without a crash or without modifications, then using the cache
> is just fine. Always parsing is _wrong_.
> I'll revert this patch. Please let us discuss how to come up with a proper
> solution to this problem.
> The other patch also could be simplified (which I did, without
> so I'm also to blame).
> Generally, please put the patches on reviewboard first.
> Milian Wolff
> mail at milianw.de
More information about the KDevelop-devel