[kdev-clang] /: Always update opened in editor documents

Milian Wolff mail at milianw.de
Wed Aug 27 11:52:23 UTC 2014

On Wednesday 27 August 2014 11:29:20 Sergey Kalinichev wrote:
> Git commit 83b50cbf3707a2e8cd8f1893c262156a3d925493 by Sergey Kalinichev.
> Committed on 26/08/2014 at 08:12.
> Pushed by skalinichev into branch 'master'.
> Always update opened in editor documents
> This is important as those files won't be reparsed properly after
> e.g. crash or if they were modified in previous session, but not closed.

Hello Sergey,

this patch is wrong I think. It work-arounds an underlying issue. When you 
open KDevelop without a crash or without modifications, then using the cache 
is just fine. Always parsing is _wrong_.

I'll revert this patch. Please let us discuss how to come up with a proper 
solution to this problem.

The other patch also could be simplified (which I did, without test-compiling, 
so I'm also to blame).

Generally, please put the patches on reviewboard first.
Milian Wolff
mail at milianw.de

More information about the KDevelop-devel mailing list