[kdev-clang] /: Always update opened in editor documents
mail at milianw.de
Wed Aug 27 13:07:10 UTC 2014
On Wednesday 27 August 2014 16:23:52 Sergey Kalinichev wrote:
> Yes, I know that you've already reverted that.
> Still I don't understand why is it so bad? Yes, it's just a
> workaround, not a proper fix, but it solves the problem. And it does
> it almost for free (without using too much resources), because it just
> reparses the currently opened document, not it's imports, that already
> up to date, so it's very fast.
You can easily end up with dozens of file open in a project which get restored
on startup. Creating parse jobs for these files for no reason is a bug as it
wastes resources. The user will also think our cache is broken as this is much
slower than just highlighting a file from the cache.
So yes, this is bad. Please open a bug report with explicit steps to reproduce
the underlying issue you want to workaround here. Then we can start the
discussion on how to fix it *properly*.
I really don't want kdev-clang to become a monster of workarounds (like other
language plugins). Instead, I want to fix things properly in kdevplatform
> P.S. Thanks for commenting on my other patches! Yes, I should have
> posted it to the review first...
> On 8/27/14, Milian Wolff <mail at milianw.de> wrote:
> > On Wednesday 27 August 2014 11:29:20 Sergey Kalinichev wrote:
> >> Git commit 83b50cbf3707a2e8cd8f1893c262156a3d925493 by Sergey Kalinichev.
> >> Committed on 26/08/2014 at 08:12.
> >> Pushed by skalinichev into branch 'master'.
> >> Always update opened in editor documents
> >> This is important as those files won't be reparsed properly after
> >> e.g. crash or if they were modified in previous session, but not closed.
> > Hello Sergey,
> > this patch is wrong I think. It work-arounds an underlying issue. When you
> > open KDevelop without a crash or without modifications, then using the
> > cache
> > is just fine. Always parsing is _wrong_.
> > I'll revert this patch. Please let us discuss how to come up with a proper
> > solution to this problem.
> > The other patch also could be simplified (which I did, without
> > test-compiling,
> > so I'm also to blame).
> > Generally, please put the patches on reviewboard first.
> > --
> > Milian Wolff
> > mail at milianw.de
> > http://milianw.de
> KDevelop-devel mailing list
> KDevelop-devel at kde.org
mail at milianw.de
More information about the KDevelop-devel