[kdev-clang] duchain: Don't use clang_getInclusions at all.
kalinichev.so.0 at gmail.com
Wed Aug 20 09:44:00 UTC 2014
>can you please comment on this change? Why is it important to find imports of .moc files?
No, no just the opposite. On reparse clang_getInclusions with
CXTranslationUnit_PrecompiledPreamble flag returns imports that not
included in preamble (e.g. .moc files) and nothing else. So instead of
figuring out whether it all imports included by the file or just some
of them I think it's better not to use clang_getInclusions at all.
>Also, if you comment out code, please add a big fat todo comment explaining
>what must be done to fix this.
Actually I've already added a TODO note for that (clanghelpers.cpp:91)...
>Esp. considering you deleted other parts of the
>code though, maybe you should remove the other code as well?
Not sure what you're talking about. I don't remember deleting anything...
On 8/20/14, Milian Wolff <mail at milianw.de> wrote:
> On Wednesday 20 August 2014 06:44:43 Sergey Kalinichev wrote:
>> Git commit fdcbcf3c59c17b63bd5e98a7ea4a9bf79d00007d by Sergey Kalinichev.
>> Committed on 19/08/2014 at 19:57.
>> Pushed by skalinichev into branch 'master'.
>> Don't use clang_getInclusions at all.
>> Yes, I've already implemented some workaround for that. But turns out
>> clang_getInclusions can find some of the imports, e.g .moc files
> Hey Sergey,
> can you please comment on this change? Why is it important to find imports
> .moc files?
> Also, if you comment out code, please add a big fat todo comment explaining
> what must be done to fix this. Esp. considering you deleted other parts of
> code though, maybe you should remove the other code as well? Otherwise, it
> will just bitrot.
> Milian Wolff
> mail at milianw.de
More information about the KDevelop-devel