[kdev-clang] duchain: Don't use clang_getInclusions at all.

Milian Wolff mail at milianw.de
Wed Aug 20 09:21:34 UTC 2014


On Wednesday 20 August 2014 06:44:43 Sergey Kalinichev wrote:
> Git commit fdcbcf3c59c17b63bd5e98a7ea4a9bf79d00007d by Sergey Kalinichev.
> Committed on 19/08/2014 at 19:57.
> Pushed by skalinichev into branch 'master'.
> 
> Don't use clang_getInclusions at all.
> 
> Yes, I've already implemented some workaround for that. But turns out
> clang_getInclusions can find some of the imports, e.g .moc files

Hey Sergey,

can you please comment on this change? Why is it important to find imports of 
.moc files? 

Also, if you comment out code, please add a big fat todo comment explaining 
what must be done to fix this. Esp. considering you deleted other parts of the 
code though, maybe you should remove the other code as well? Otherwise, it 
will just bitrot.

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de


More information about the KDevelop-devel mailing list