[kdev-clang] duchain: Don't use clang_getInclusions at all.

[Milian Wolff]

On Wednesday 20 August 2014 13:44:00 Sergey Kalinichev wrote:
> Hi,
> 
> >can you please comment on this change? Why is it important to find imports
> >of .moc files?
> No, no just the opposite. On reparse clang_getInclusions with
> CXTranslationUnit_PrecompiledPreamble flag returns imports that not
> included in preamble (e.g. .moc files) and nothing else. So instead of
> figuring out whether it all imports included by the file or just some
> of them I think it's better not to use clang_getInclusions at all.

Thanks for the clarification, I see how this is an issue.

> >Also, if you comment out code, please add a big fat todo comment explaining
> >what must be done to fix this.
> 
> Actually I've already added a TODO note for that (clanghelpers.cpp:91)...
> 
> >Esp. considering you deleted other parts of the
> >code though, maybe you should remove the other code as well?
> 
> Not sure what you're talking about. I don't remember deleting anything...

To both: True - I'm apparently bad at reading code in my email program without 
proper syntax highlighting.

Bye, sorry for the noise.
-- 
Milian Wolff
mail at milianw.de
http://milianw.de