Review Request 116795: Fixed the parsing of hexadecimals and binary literals

[Miquel Sabaté Solà]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116795/
-----------------------------------------------------------

(Updated April 29, 2014, 10:43 a.m.)


Review request for KDevelop.


Changes
-------

Fixed the issue pointed out by Milian. I've also added a test.


Repository: kdev-php


Description
-------

According to http://www.php.net/manual/en/language.types.integer.php , in PHP integers can also be specified with the binary syntax. This patch allows the lexer to handle binary literals as a regular numeric literal. Moreover, the hexadecimal handling didn't handle hexadecimal literals such as 0X1234 (note the uppercase 'X'). This patch also fixes this.


Diffs (updated)
-----

  parser/phplexer.cpp 0a1fe67 
  parser/test/lexertest.h 9ecd74f 
  parser/test/lexertest.cpp 963deca 

Diff: https://git.reviewboard.kde.org/r/116795/diff/


Testing
-------

Manual testing.


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140429/cbe0f708/attachment.html>