Review Request 116795: Fixed the parsing of hexadecimals and binary literals

Miquel Sabaté Solà mikisabate at
Tue Apr 29 10:52:04 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated April 29, 2014, 10:52 a.m.)

Review request for KDevelop.


Added a test for hexadecimal numeric literals.

Repository: kdev-php


According to , in PHP integers can also be specified with the binary syntax. This patch allows the lexer to handle binary literals as a regular numeric literal. Moreover, the hexadecimal handling didn't handle hexadecimal literals such as 0X1234 (note the uppercase 'X'). This patch also fixes this.

Diffs (updated)

  parser/phplexer.cpp 0a1fe67 
  parser/test/lexertest.h 9ecd74f 
  parser/test/lexertest.cpp 963deca 



Manual testing.


Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list