Review Request 116795: Fixed the parsing of hexadecimals and binary literals

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116795/#review56836
-----------------------------------------------------------

Ship it!


please add a test, then go for it!

thanks


parser/phplexer.cpp
<https://git.reviewboard.kde.org/r/116795/#comment39658>

    toLower for the == 'b' here as well, no?


- Milian Wolff


On March 14, 2014, 9:28 a.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116795/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 9:28 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> According to http://www.php.net/manual/en/language.types.integer.php , in PHP integers can also be specified with the binary syntax. This patch allows the lexer to handle binary literals as a regular numeric literal. Moreover, the hexadecimal handling didn't handle hexadecimal literals such as 0X1234 (note the uppercase 'X'). This patch also fixes this.
> 
> 
> Diffs
> -----
> 
>   parser/phplexer.cpp 0a1fe67 
> 
> Diff: https://git.reviewboard.kde.org/r/116795/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140429/2ee179bb/attachment.html>