Review Request 117352: Adding completion support for const qualified virtual functions

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117352/#review55104
-----------------------------------------------------------


This review has been submitted with commit d801ff02379c61f143fb9e90d1e6042bcc7cf137 by David Stevens to branch master.

- Commit Hook


On April 3, 2014, 3:35 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117352/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 3:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Added support for the const qualifier on virtual functions to the code completion helper. Unfortunately, the current clang-c api doesn't offer a good way to do this, so I parsed clang's undocumented cursor USR. A working solution, but not a great one.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 3a93669 
>   codecompletion/overridecompletionhelper.h 434ab9f 
>   codecompletion/overridecompletionhelper.cpp 398c85f 
>   tests/codecompletiontest.h 254aab8 
>   tests/codecompletiontest.cpp 2d8ed53 
> 
> Diff: https://git.reviewboard.kde.org/r/117352/diff/
> 
> 
> Testing
> -------
> 
> Manual and added a unit test.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140407/ed352b8f/attachment-0001.html>