Review Request 117352: Adding completion support for const qualified virtual functions

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117352/#review55038
-----------------------------------------------------------

Ship it!


LGTM.

For the curious people out there, here's a bit of documentation about USR and parsing it: http://stackoverflow.com/questions/12026551/how-to-find-out-whether-a-member-function-is-const-or-volatile-with-libclang

We have a unittest, so we'll see in case this hack breaks...

- Kevin Funk


On April 3, 2014, 3:35 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117352/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 3:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Added support for the const qualifier on virtual functions to the code completion helper. Unfortunately, the current clang-c api doesn't offer a good way to do this, so I parsed clang's undocumented cursor USR. A working solution, but not a great one.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 3a93669 
>   codecompletion/overridecompletionhelper.h 434ab9f 
>   codecompletion/overridecompletionhelper.cpp 398c85f 
>   tests/codecompletiontest.h 254aab8 
>   tests/codecompletiontest.cpp 2d8ed53 
> 
> Diff: https://git.reviewboard.kde.org/r/117352/diff/
> 
> 
> Testing
> -------
> 
> Manual and added a unit test.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140405/a2eb9592/attachment.html>