Review Request 117352: Adding completion support for const qualified virtual functions

David Stevens dgedstevens at gmail.com
Mon Apr 7 03:37:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117352/
-----------------------------------------------------------

(Updated April 7, 2014, 3:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdev-clang


Description
-------

Added support for the const qualifier on virtual functions to the code completion helper. Unfortunately, the current clang-c api doesn't offer a good way to do this, so I parsed clang's undocumented cursor USR. A working solution, but not a great one.


Diffs
-----

  codecompletion/context.cpp 3a93669 
  codecompletion/overridecompletionhelper.h 434ab9f 
  codecompletion/overridecompletionhelper.cpp 398c85f 
  tests/codecompletiontest.h 254aab8 
  tests/codecompletiontest.cpp 2d8ed53 

Diff: https://git.reviewboard.kde.org/r/117352/diff/


Testing
-------

Manual and added a unit test.


Thanks,

David Stevens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140407/2bac4ce9/attachment.html>


More information about the KDevelop-devel mailing list