Review Request 113473: Project Manager filter delay

[Sven Brauch]

> On Oct. 27, 2013, 4:34 p.m., Sven Brauch wrote:
> > I'm known for hating those delays with a passion ;)
> > But if it has to be there, it has to be there. I'd however suggest to go for KDE's default of 300ms instead of 1s.
> 
> Eugene Agafonov wrote:
>     300ms is not enough. It triggers filter updates when I types filter. May be I'm too slow. Any way I'd prefer make it configurable.

The patch looks ok now.
Well, 300ms is what we use for e.g. quickopen, which has exactly the same issue. So why would we use a different delay here?


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113473/#review42453
-----------------------------------------------------------


On Oct. 28, 2013, 6:26 p.m., Eugene Agafonov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113473/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 6:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Project Manager's filter triggers every time when user hits the key. It became annoying with big projects once filter update may takes a noticible time.
> 
> This patch implements a delay (1 sec in current implementation) between the user stops typing and filter update.
> 
> The delay is implemented in ProjectManagerFilterAction so neither ProjectProxyMorel nor ProjectManager view is touched by this patch. ProjectManagerFilterAction's interface is not changed as well.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.h 020d24fcb71a6ea6a73effe62d5b3668060eab3f 
>   plugins/projectmanagerview/projectmanagerview.cpp fbec9add4035c4ffd4e3e28a4acd7c75d420ddc6 
> 
> Diff: http://git.reviewboard.kde.org/r/113473/diff/
> 
> 
> Testing
> -------
> 
> Build and test on master branches with my dayly-work projects (10+ projects in single sessions, 5000+files of different types)
> 
> 
> Thanks,
> 
> Eugene Agafonov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131028/7d79393a/attachment.html>