<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113473/">http://git.reviewboard.kde.org/r/113473/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 27th, 2013, 4:34 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm known for hating those delays with a passion ;)
But if it has to be there, it has to be there. I'd however suggest to go for KDE's default of 300ms instead of 1s.</pre>
</blockquote>
<p>On October 28th, 2013, 6:27 p.m. UTC, <b>Eugene Agafonov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">300ms is not enough. It triggers filter updates when I types filter. May be I'm too slow. Any way I'd prefer make it configurable. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch looks ok now.
Well, 300ms is what we use for e.g. quickopen, which has exactly the same issue. So why would we use a different delay here?</pre>
<br />
<p>- Sven</p>
<br />
<p>On October 28th, 2013, 6:26 p.m. UTC, Eugene Agafonov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Eugene Agafonov.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 6:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Project Manager's filter triggers every time when user hits the key. It became annoying with big projects once filter update may takes a noticible time.
This patch implements a delay (1 sec in current implementation) between the user stops typing and filter update.
The delay is implemented in ProjectManagerFilterAction so neither ProjectProxyMorel nor ProjectManager view is touched by this patch. ProjectManagerFilterAction's interface is not changed as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build and test on master branches with my dayly-work projects (10+ projects in single sessions, 5000+files of different types)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/projectmanagerview.h <span style="color: grey">(020d24fcb71a6ea6a73effe62d5b3668060eab3f)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(fbec9add4035c4ffd4e3e28a4acd7c75d420ddc6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113473/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>