Review Request 113473: Project Manager filter delay

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113473/#review42455
-----------------------------------------------------------



plugins/projectmanagerview/projectmanagerview.cpp
<http://git.reviewboard.kde.org/r/113473/#comment30815>

    You can just connect(..., SIGNAL(), SIGNAL()), no need for the extra function.



plugins/projectmanagerview/projectmanagerview.cpp
<http://git.reviewboard.kde.org/r/113473/#comment30816>

    Calling start() will re-start the timer if it's running, so no need for calling stop().
    
    You can probably just connect(..., SIGNAL(textChanged()), timer, SLOT(start()), and then use the current filter string insted of the saved one, no?


- Sven Brauch


On Oct. 27, 2013, 4:26 p.m., Eugene Agafonov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113473/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2013, 4:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Project Manager's filter triggers every time when user hits the key. It became annoying with big projects once filter update may takes a noticible time.
> 
> This patch implements a delay (1 sec in current implementation) between the user stops typing and filter update.
> 
> The delay is implemented in ProjectManagerFilterAction so neither ProjectProxyMorel nor ProjectManager view is touched by this patch. ProjectManagerFilterAction's interface is not changed as well.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.h 020d24f 
>   plugins/projectmanagerview/projectmanagerview.cpp fbec9ad 
> 
> Diff: http://git.reviewboard.kde.org/r/113473/diff/
> 
> 
> Testing
> -------
> 
> Build and test on master branches with my dayly-work projects (10+ projects in single sessions, 5000+files of different types)
> 
> 
> Thanks,
> 
> Eugene Agafonov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131027/2d53d103/attachment.html>