Review Request 109642: Make it possible to have navigation widgets stay open when the cursor is moved in the document

Aleix Pol Gonzalez aleixpol at gmail.com
Thu Mar 21 17:38:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109642/#review29642
-----------------------------------------------------------

Ship it!


It's not pretty, but it's functional. :)

- Aleix Pol Gonzalez


On March 21, 2013, 3:43 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109642/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 3:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This adds a property to the widget you return from your createNavigationWidget method which tells kdevplatform to keep the widget open when the cursor moves in the document.
> It's required for this thing I'm currently creating for kdev-qmljs:
> http://files.feorar.org/color3.gif
> Without this patch, the widget will always close if the color is updated once, which destroys the nice live-feedback effect it has otherwise.
> I'm not sure if using Qt's property system is the right way to go in this case (it's the easiest way for sure), which is why I'm submitting this for review.
> 
> Also this patch fixes a typo (createTooTip) and uses Qt::UniqueConnection instead of disconnect-reconnect.
> 
> 
> Diffs
> -----
> 
>   language/duchain/ducontext.h b6665f1 
>   language/interfaces/ilanguagesupport.h 34dae9a 
>   plugins/contextbrowser/contextbrowser.h e6d82f7 
>   plugins/contextbrowser/contextbrowser.cpp 110b8ec 
> 
> Diff: http://git.reviewboard.kde.org/r/109642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130321/13e3c551/attachment.html>


More information about the KDevelop-devel mailing list