Review Request 109642: Make it possible to have navigation widgets stay open when the cursor is moved in the document

Sven Brauch svenbrauch at
Thu Mar 21 15:44:00 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated March 21, 2013, 3:43 p.m.)

Review request for KDevelop.


Yes I thought so too -- an enum is self-documenting at least to some degree, while this is not at all. Do you think the attached is sufficient?


This adds a property to the widget you return from your createNavigationWidget method which tells kdevplatform to keep the widget open when the cursor moves in the document.
It's required for this thing I'm currently creating for kdev-qmljs:
Without this patch, the widget will always close if the color is updated once, which destroys the nice live-feedback effect it has otherwise.
I'm not sure if using Qt's property system is the right way to go in this case (it's the easiest way for sure), which is why I'm submitting this for review.

Also this patch fixes a typo (createTooTip) and uses Qt::UniqueConnection instead of disconnect-reconnect.

Diffs (updated)

  language/duchain/ducontext.h b6665f1 
  language/interfaces/ilanguagesupport.h 34dae9a 
  plugins/contextbrowser/contextbrowser.h e6d82f7 
  plugins/contextbrowser/contextbrowser.cpp 110b8ec 




Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list