<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109642/">http://git.reviewboard.kde.org/r/109642/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not pretty, but it's functional. :)</pre>
<br />
<p>- Aleix</p>
<br />
<p>On March 21st, 2013, 3:43 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a property to the widget you return from your createNavigationWidget method which tells kdevplatform to keep the widget open when the cursor moves in the document.
It's required for this thing I'm currently creating for kdev-qmljs:
http://files.feorar.org/color3.gif
Without this patch, the widget will always close if the color is updated once, which destroys the nice live-feedback effect it has otherwise.
I'm not sure if using Qt's property system is the right way to go in this case (it's the easiest way for sure), which is why I'm submitting this for review.
Also this patch fixes a typo (createTooTip) and uses Qt::UniqueConnection instead of disconnect-reconnect.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/duchain/ducontext.h <span style="color: grey">(b6665f1)</span></li>
<li>language/interfaces/ilanguagesupport.h <span style="color: grey">(34dae9a)</span></li>
<li>plugins/contextbrowser/contextbrowser.h <span style="color: grey">(e6d82f7)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(110b8ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109642/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>