Review Request 109610: A new splash screen for kdevelop (animation attached)

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109610/
-----------------------------------------------------------

(Updated March 20, 2013, 8:44 p.m.)


Review request for KDevelop.


Changes
-------

I have fixed 2, 3, 4.
About the QApplication::processEvents, this is necessary because the event loop is not yet running (the application is starting up), but the splash screen needs to be redrawn. This was not necessary before because the splash screen was static, and didn't need redrawing. Calling QApplication::processEvents() is also described in the Qt documentation as the correct way to update the splash screen while the application is starting: http://qt-project.org/doc/qt-4.8/qsplashscreen.html

Cheers


Description
-------

This is my suggestion for a new splash screen in kdevelop. Sure, application startup is short anyways, but we've had the current splash screen for ages and it's time for something new. ;)

Click here for what it looks like: http://files.feorar.org/splash.gif
Be careful, it's 3.5MB gif.

It needs a patch to kdevplatform for the progress info, which I'll submit shortly (it works without too, but you'll only see grey squares).


Diffs (updated)
-----

  pics/misc/kdevelop-splash.xcf fdd2b40cbe7c6096f77519f1706cec3846a29696 
  pics/misc/kdevelop-splash.png cf161cb634c6c3f24b743706294078eb3ed16d94 
  app/splash.qml PRE-CREATION 
  app/splash.cpp PRE-CREATION 
  app/splash.h PRE-CREATION 
  app/main.cpp 4ad8f05 
  app/CMakeLists.txt c0e10ed 

Diff: http://git.reviewboard.kde.org/r/109610/diff/


Testing
-------

I verified that even if something goes wrong in QML there's no crashes or strange behavior. You'll just get the splash screen without the colorful squares. Thus I think the risk of breaking something with this is low.


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130320/7c21d547/attachment.html>