Review Request 109610: A new splash screen for kdevelop (animation attached)

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109610/#review29583
-----------------------------------------------------------


In addition to the below, I'm somehow missing the connection between the new Core signal and the signal (or slot) of the splashscreen


app/main.cpp
<http://git.reviewboard.kde.org/r/109610/#comment22073>

    Why is this necessary? It wasn't necessary so far, so whats needing this?



app/splash.cpp
<http://git.reviewboard.kde.org/r/109610/#comment22070>

    debug output, please remove.



app/splash.cpp
<http://git.reviewboard.kde.org/r/109610/#comment22072>

    Very bad parameter name here.



app/splash.cpp
<http://git.reviewboard.kde.org/r/109610/#comment22071>

    So this would actually be easier with an int as progress information.


- Andreas Pakulat


On March 20, 2013, 4:47 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109610/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 4:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is my suggestion for a new splash screen in kdevelop. Sure, application startup is short anyways, but we've had the current splash screen for ages and it's time for something new. ;)
> 
> Click here for what it looks like: http://files.feorar.org/splash.gif
> Be careful, it's 3.5MB gif.
> 
> It needs a patch to kdevplatform for the progress info, which I'll submit shortly (it works without too, but you'll only see grey squares).
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt c0e10ed 
>   app/main.cpp 4ad8f05 
>   app/splash.h PRE-CREATION 
>   app/splash.cpp PRE-CREATION 
>   app/splash.qml PRE-CREATION 
>   pics/misc/kdevelop-splash.png cf161cb634c6c3f24b743706294078eb3ed16d94 
>   pics/misc/kdevelop-splash.xcf fdd2b40cbe7c6096f77519f1706cec3846a29696 
> 
> Diff: http://git.reviewboard.kde.org/r/109610/diff/
> 
> 
> Testing
> -------
> 
> I verified that even if something goes wrong in QML there's no crashes or strange behavior. You'll just get the splash screen without the colorful squares. Thus I think the risk of breaking something with this is low.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130320/26455a6a/attachment.html>