<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109610/">http://git.reviewboard.kde.org/r/109610/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated March 20, 2013, 8:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have fixed 2, 3, 4.
About the QApplication::processEvents, this is necessary because the event loop is not yet running (the application is starting up), but the splash screen needs to be redrawn. This was not necessary before because the splash screen was static, and didn't need redrawing. Calling QApplication::processEvents() is also described in the Qt documentation as the correct way to update the splash screen while the application is starting: http://qt-project.org/doc/qt-4.8/qsplashscreen.html
Cheers</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my suggestion for a new splash screen in kdevelop. Sure, application startup is short anyways, but we've had the current splash screen for ages and it's time for something new. ;)
Click here for what it looks like: http://files.feorar.org/splash.gif
Be careful, it's 3.5MB gif.
It needs a patch to kdevplatform for the progress info, which I'll submit shortly (it works without too, but you'll only see grey squares).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I verified that even if something goes wrong in QML there's no crashes or strange behavior. You'll just get the splash screen without the colorful squares. Thus I think the risk of breaking something with this is low.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>pics/misc/kdevelop-splash.xcf <span style="color: grey">(fdd2b40cbe7c6096f77519f1706cec3846a29696)</span></li>
<li>pics/misc/kdevelop-splash.png <span style="color: grey">(cf161cb634c6c3f24b743706294078eb3ed16d94)</span></li>
<li>app/splash.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/splash.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/splash.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/main.cpp <span style="color: grey">(4ad8f05)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(c0e10ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>