branch name appended to project name

[Milian Wolff]

On Sunday 17 March 2013 14:21:33 Kevin Funk wrote:
> On Sunday 17 March 2013, 12:51, Kevin Funk wrote:
> > On Sunday 17 March 2013, 09:09, Andreas Pakulat wrote:
> > > Hi,
> > > 
> > > On Sun, Mar 17, 2013 at 8:00 AM, Jeremy Murphy
> > > 
> > > <jeremy.william.murphy at gmail.com> wrote:
> > > > Hi everyone,
> > > > 
> > > > I just noticed that the Projects panel now displays the branch name in
> > > > parentheses after the project name, which is nice, thank you.  But I
> > > > don't
> > > > think it is ideal.  :)  The problem is that it is not distinguishable
> > > > from
> > > > a valid project name.  Is it possible to do something to the branch
> > > > name
> > > > font to distinguish it?
> > > 
> > > Yes this is possible, unfortunately its not quite as easy as in
> > > Eclipse since the Qt ItemViews do not provide a decoration-metaphor.
> > 
> > I fully agree with Jeremy, there should be some disambiguation.
> > 
> > maybe something like [1] would fit in here?
> > 
> > The VcsOverlayProxyModel introduced by Alex could define a new role for
> > the
> > VCS data and in QItemDelegate::paint we do:
> > - paint role Qt::DisplayRole normally
> > - paint role VcsOverlayProxyModel::VcsDataRole with QPalette::brightText
> > or
> > whatever (only in case data(index, VcsOverlayProxyModel::VcsDataRole)
> > returns valid data)
> > 
> > A different but more simple solution: Just add another column in the proxy
> > model, and for that column return a different column for Qt::FontRole.
> > (Of course, that means we have a different text alignment then).
> > 
> > [1]
> > http://qt-project.org/faq/answer/how_can_i_modify_the_color_for_individual
> > _
> > words_for_ite ms_in_a_view
> 
> Hm, following up on that.
> 
> I just noticed that the 'VCS changes' tool view already does what we want.
> 
> Why don't we just merge the 'VCS changes' tool view with the project manager
> view? E.g. keep the project manager view as-is, and add a 'VCS status'
> column to the project manager view.

We don't have enough space there imo to add another column. Furthermore the 
VCS changes toolbar is supposed to show a short digest of all VCS changes and 
should not be cluttered by non-changed files.

What I _do_ want though, is sharing code between the two and add additional UI 
hints for added, untracked, changed, ... files in our project manager view - 
similar e.g. to how Dolphin or Eclipse do it.

> Idea:
> - For the root project item -> show branch name / indicate if it is modified
> - For folder/file -> indicate if it is modified
or untracked, or added, or ...

I would welcome this a lot! But the big question will be how to make it fast 
enough. The "git status" or similar should probably be parsed in a background 
thread whenever a project is opened. Then similarily we should query the DVCS 
plugin for file status whenever a file was saved. Same for signals about 
new/removed files/folders via the project manager plugin. But how do we get 
notified about external file changes of non-opened files?

Cheers
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/b1a4b92f/attachment.sig>